Author:  lovaquero  Posted:  Aug 21, 2014 12:09  Subject:  Store View Tabs Missing [SOLUTION]  Viewed:  175 times  Topic:  Suggestions  Status: Discarded Cancel Reply	BrickLink ID Card lovaquero (2128) Location:  USA, Indiana Member Since Contact Type Status Jan 29, 2009 Seller   Store: Lo's Parts & Pieces
(Below is the solution to fix the missing tabs problem that currently exists on Bricklink. It is a copy of the message I sent to admin. Posting it here for more visibility. It took me longer to make the images and type the note explaining the solution than it took to find the problem...) The root cause is directly related to the addition of the 'link' that switches the pages from Engling Chinese. It forces the HTML table to take up more space than is necessary, thus pushing the table the contains the tabs out of the viewable area. The images show the code - it is a true (and badly done) hack. Anyway, enough commenaty, here is the fix: Bricklink Developers & Admin - Attached is an image detailing the a solution that will correct the tab rendering (hidden tabs) problem experienced on certain browsers. The problem is a rendering difference between browsers related to how they interpret and implement HTML/CSS. ------------------------------------------------ The Root Cause is a combination of the following: ------------------------------------------------ 1 - HTML4 v HTML5 support on BL (related to Splash page problems as well) 2 - Old ASP framework code v Modern HTML/CSS standards 3 - A really bad code hack to provide the link to switch to Chinese BL (I mean no offence - there is no other way to describe it) 4 - Insuffient testing before release. -------- Code Fix: -------- #1 - Change the table tag's CELLPADDING attibute from CELLPADDING="5" to CELLPADDING="0" (It is not needed, but the 10px vertical pixels it frees up are needed #2 - ADD "margin:0;padding:0;" to the style attribute of the UL tag utilized to implement the Chinese language switch (most browsers will automatically do this, others will not until forced to. This will stop the parent table from pushing the tabs out of the viewable space in the top frame. #3 - Add VALIGN="TOP" to the TD tag that wraps the section containing the Store flags. This will force the flag images to the top of the table, similar to what is done with the BL logo Another temp solution is to set SCROLLING="YES" for the FRAME that loads the store banner and tabs. This would also allow folks to atleast scroll down the tabs The Permenant solution is to fix the code hack used to implement the Chinese language page link. It is improperly implemented - you shouldn't be using UL LI to create the script link, and there are better ways to align the link beyond using 10x not-breaking spaces... Thank you Rodney Pearson Lovaquero

Message Has 4 Replies:

Re: Store View Tabs Missing [SOLUTION] - lovaquero (2128)

A (hopefully) more readable image of the code mentioned above. Apologies on the typos in the OP - I am used to my customize code editor, and not so much to document creation. [...] (119 months ago, Aug 21, 2014, to Suggestions)

Re: Store View Tabs Missing [SOLUTION] - picabo (2037)

[...] Thanks Rodney. Pam [...] (119 months ago, Aug 21, 2014, to Suggestions)

Re: Store View Tabs Missing [SOLUTION] - StarBrick (7086)

Wow, did you post this to the helpdesk too? (119 months ago, Aug 21, 2014, to Suggestions)

Re: Store View Tabs Missing [SOLUTION] - lovaquero (2128)

I neglected to mention it before, but there IS a user-side workaround (at least for IE users) to see the store view tabs. This should work until BL dev team is able [...] (119 months ago, Aug 21, 2014, to Suggestions)

15 Messages in this Thread:

 Msg 1 « - lovaquero (2128) 119 months ago Aug 21, 2014 to Suggestions
 Msg 2 - lovaquero (2128) 119 months ago Aug 21, 2014 to Suggestions
 Msg 3 - QA_Ryan (3) 119 months ago Aug 21, 2014 to Suggestions
 Msg 4 - picabo (2037) 119 months ago Aug 21, 2014 to Suggestions
 Msg 5 - StarBrick (7086) 119 months ago Aug 21, 2014 to Suggestions
 Msg 6 - lovaquero (2128) 119 months ago Aug 21, 2014 to Suggestions
 Msg 7 - StarBrick (7086) 119 months ago Aug 21, 2014 to Suggestions
 Msg 8 - lovaquero (2128) 119 months ago Aug 21, 2014 to Suggestions
 Msg 9 - par016 (7685) 119 months ago Aug 21, 2014 to Suggestions
 Msg 10 - lovaquero (2128) 119 months ago Aug 21, 2014 to Suggestions
 Msg 11 - lovaquero (2128) 119 months ago Aug 21, 2014 to Suggestions
 Msg 12 - Andy_Bell (2367) 119 months ago Aug 21, 2014 to Suggestions
 Msg 13 - lovaquero (2128) 119 months ago Aug 21, 2014 to Suggestions
 Msg 14 - Andy_Bell (2367) 119 months ago Aug 22, 2014 to Suggestions
 Msg 15 - BLUSER_36530 (810) 119 months ago Aug 22, 2014 to Suggestions